[llvm] r286062 - Kill deprecated attribute API

whitequark via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 11:01:03 PST 2016


On 2016-11-08 18:15, Kostya Serebryany wrote:
> Amaury,
> Please either fix or revert ASAP, we need the bots to be green.
> If this is an intentional breakage, please update the bot
> configuration.

As the OCaml binding maintainer, I ask you to revert.
I am on it, but migrating to the new attribute API is a significant
change and I won't be able to quickly perform it.

> 
> On Tue, Nov 8, 2016 at 7:23 AM, Dmitri Gribenko via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> 
>> On Sun, Nov 6, 2016 at 10:40 PM, Dmitri Gribenko
>> <gribozavr at gmail.com> wrote:
>>> On Sun, Nov 6, 2016 at 12:48 AM, Amaury Sechet via llvm-commits
>>> <llvm-commits at lists.llvm.org> wrote:
>>>> Author: deadalnix
>>>> Date: Sun Nov  6 01:48:46 2016
>>>> New Revision: 286062
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=286062&view=rev [1]
>>>> Log:
>>>> Kill deprecated attribute API
>>>> 
>>>> Summary:
>>>> This kill various depreacated API related to attribute :
>>>> - The deprecated C API attribute based on LLVMAttribute enum.
>>>> - The Raw attribute set format (planned to be removed in 4.0).
>>> 
>>> Hi Amaury,
>>> 
>>> This change broke OCaml bindings:
>>> 
>>> 
>> 
> http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/197/steps/test/logs/stdio
>> [2]
>>> 
>>> Please take a look.
>> 
>> Ping?
>> 
>> Dmitri
>> 
>> --
>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits [3]
> 
> 
> 
> Links:
> ------
> [1] http://llvm.org/viewvc/llvm-project?rev=286062&view=rev
> [2]
> http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/197/steps/test/logs/stdio
> [3] http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 
whitequark


More information about the llvm-commits mailing list