[PATCH] D26230: [AddressSanitizer] Add support for (constant-)masked loads and stores.

[Kostya Serebryany via llvm-commits]

kcc added a comment.

Could you please also add a test to compiler-rt/test/asan?
(you can do it as a separate Phab patch, if that's more convenient)



================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1183
+  if (MaybeMask) {
+    auto Mask = cast<ConstantVector>(MaybeMask);
+    auto *VTy = cast<PointerType>(Addr->getType())->getElementType();
----------------
could you please outline this into its own function, just as you did with doInstrumentAddress?


https://reviews.llvm.org/D26230