[PATCH] D26389: [SCEV] limit recursion depth of CompareSCEVComplexity

[Sanjoy Das via llvm-commits]

sanjoy added a comment.

Hi Dmitry,

Please upload the patch with context (http://llvm.org/docs/Phabricator.html)

Have you checked if this is solely due to the depth of the expressions, or if this is due to some exponential behavior?  Can this be solved using a cache, like in `CompareValueComplexity` (though it also has a `Depth` so perhaps it isn't a good example).

As far as the test case goes, you can always add a C++ test case to unittests/ that generates the IR or SCEV expression in memory.  I agree with you in that we should avoid adding excessively large test files to tests/


https://reviews.llvm.org/D26389