[PATCH] D26374: Add documentation for the PDB file format

[David Majnemer via llvm-commits]

majnemer added inline comments.


================
Comment at: docs/PDB/MsfFile.rst:20
+    ulittle32_t BlockSize;
+    ulittle32_t FreeBlockMapBlock;
+    ulittle32_t NumBlocks;
----------------
I think this name would be a little more self-descriptive if it were called `FreeBlockMapAddr`.  This would also make it consistent with `BlockMapAddr`.


================
Comment at: docs/PDB/MsfFile.rst:24
+    ulittle32_t Unknown;
+    ulittle32_t BlockMapAddr;
+  };
----------------
Looking at the microsoft-pdb sources, isn't this technically an array of addresses?
https://github.com/Microsoft/microsoft-pdb/blob/master/PDB/msf/msf.cpp#L954


https://reviews.llvm.org/D26374