[PATCH] D26347: Fix memory leaks (coverity issues 1365586 & 1365591)

Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 02:10:37 PST 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL286223: Fix memory leaks (coverity issues 1365586 & 1365591) (authored by sylvestre).

Changed prior to commit:
  https://reviews.llvm.org/D26347?vs=77017&id=77161#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D26347

Files:
  llvm/trunk/lib/Support/APFloat.cpp


Index: llvm/trunk/lib/Support/APFloat.cpp
===================================================================
--- llvm/trunk/lib/Support/APFloat.cpp
+++ llvm/trunk/lib/Support/APFloat.cpp
@@ -1686,8 +1686,10 @@
   bool ignored;
   fs = V.convertToInteger(x, parts * integerPartWidth, true,
                           rmNearestTiesToEven, &ignored);
-  if (fs==opInvalidOp)
+  if (fs==opInvalidOp) {
+    delete[] x;
     return fs;
+  }
 
   fs = V.convertFromZeroExtendedInteger(x, parts * integerPartWidth, true,
                                         rmNearestTiesToEven);
@@ -1724,8 +1726,10 @@
     bool ignored;
     fs = V.convertToInteger(x, parts * integerPartWidth, true,
                             rmTowardZero, &ignored);
-    if (fs==opInvalidOp)
+    if (fs==opInvalidOp) {
+      delete[] x;
       return fs;
+    }
 
     fs = V.convertFromZeroExtendedInteger(x, parts * integerPartWidth, true,
                                           rmNearestTiesToEven);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26347.77161.patch
Type: text/x-patch
Size: 981 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161108/d89a7780/attachment.bin>


More information about the llvm-commits mailing list