[PATCH] D25385: Make the FunctionComparator of the MergeFunctions pass a stand-alone utility in a separate file

[Dean Michael Berris via llvm-commits]

dberris added inline comments.


================
Comment at: unittests/Transforms/Utils/FunctionComparator.cpp:21
+struct TestFunction {
+
+  Function *F;
----------------
nit: Don't think you need this space here.


================
Comment at: unittests/Transforms/Utils/FunctionComparator.cpp:109
+
+/// A sanity check for the FunctionComparator API.
+TEST(FunctionComparatorTest, TestAPI) {
----------------
Does this one test cover enough of the cases? I see one set of calls for the same function, without covering negative cases -- though I suspect since this is a refactoring that other tests ensure that this doing what is intended?

More concretely -- have you considered breaking up the big function API into smaller pieces that can be tested independently?


https://reviews.llvm.org/D25385