[PATCH] D22924: [GlobalISel] Permit select() to erase.

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 23:24:56 PST 2016


dberris added a comment.

Drive-by review here.



================
Comment at: lib/CodeGen/GlobalISel/InstructionSelect.cpp:75-78
+      if (MII == Begin)
+        ReachedBegin = true;
+      else
+        --MII;
----------------
nit: How about doing the --MII in the for statement?

  for (auto MII = ...; !ReachedBegin; --MII) {
    ...
    ReachedBegin = MII == Begin;
    ...
  }


https://reviews.llvm.org/D22924





More information about the llvm-commits mailing list