[PATCH] D26384: IR, Bitcode: Change bitcode reader to no longer own its memory buffer.
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 7 21:56:47 PST 2016
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM, with one nit inline.
================
Comment at: llvm/include/llvm/IR/Module.h:811
+ /// Take ownership of the given memory buffer.
+ void takeMemoryBuffer(std::unique_ptr<MemoryBuffer> MB);
};
----------------
`take` seems reversed here, I usually see it the opposite way: when the client of the API takes ownership of something that is owned by the object.
https://reviews.llvm.org/D26384
More information about the llvm-commits
mailing list