[test-suite] r286192 - After some discussion, having -flto as a default in -Os builds is a bad idea

[Mehdi Amini via llvm-commits]

Hi Chris,

> On Nov 7, 2016, at 5:22 PM, Chris Matthews via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: cmatthews
> Date: Mon Nov  7 19:22:54 2016
> New Revision: 286192
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=286192&view=rev
> Log:
> After some discussion, having -flto as a default in -Os builds is a bad idea

Can you elaborate? Maybe pointing at the discussion or summarizing the arguments? I’m curious as of why is that?

(Ideally having this information in the commit message seems like the best for future references).

Thanks!

Mehdi


> 
> Modified:
>    test-suite/trunk/cmake/caches/CodeSize.cmake
> 
> Modified: test-suite/trunk/cmake/caches/CodeSize.cmake
> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/cmake/caches/CodeSize.cmake?rev=286192&r1=286191&r2=286192&view=diff
> ==============================================================================
> --- test-suite/trunk/cmake/caches/CodeSize.cmake (original)
> +++ test-suite/trunk/cmake/caches/CodeSize.cmake Mon Nov  7 19:22:54 2016
> @@ -1,5 +1,5 @@
> # Use -Os, don't increase code size.
> 
> -set(CMAKE_C_FLAGS_RELEASE "-Os -flto" CACHE STRING "")
> -set(CMAKE_CXX_FLAGS_RELEASE "-Os -flto" CACHE STRING "")
> +set(CMAKE_C_FLAGS_RELEASE "-Os" CACHE STRING "")
> +set(CMAKE_CXX_FLAGS_RELEASE "-Os" CACHE STRING "")
> set(CMAKE_BUILD_TYPE "Release" CACHE STRING "")
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits