[PATCH] D26333: [AVX-512] Add unmasked version of shift by immediate and shift by single element in XMM.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 14:50:19 PST 2016


RKSimon added a comment.

In https://reviews.llvm.org/D26333#588337, @craig.topper wrote:

> No., I can add it. Or it will be implicitly tested once I autoupgrade the original intrinsics to these intrinsics plus select.


Adding an explicit test now would be better I think - which just made me realise if/when we do start removing upgrades we might be in danger of losing such test coverage if we're not careful!


https://reviews.llvm.org/D26333





More information about the llvm-commits mailing list