[PATCH] D26255: [cmake] Rename HAVE_DIA_SDK to LLVM_ENABLE_DIA_SDK, and expose in LLVMConfig

[Chris Bieneman via llvm-commits]

beanz added a comment.

I think you're conflating two different types of variables, and I don't understand why.

`LLVM_ENABLE_*` variables are intended to be used for people to opt in or out of functionality. `HAVE_*` variables are for compiler checks against the system capabilities. Generally system capabilities shouldn't be captured in LLVM installed bits, which is what you're doing here.

I think the correct solution would be for you to perform the `HAVE_DIA_SDK` check in LLDB as well as LLVM. If the code is sufficiently complex, the LLVM version of the code could be abstracted into a module and re-used.


https://reviews.llvm.org/D26255