[PATCH] D26357: [SelectionDAG] Add a signed integer absolute intrinsic

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 12:29:51 PST 2016


efriedma added a comment.

Please propose the IR intrinsic on llvmdev; it isn't obvious we actually want it.

Moving ABS from the x86-specific opcodes to the general set of SelectionDAG opcodes seems reasonable, given that ABS instructions are pretty common in vector ISAs.



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:19775
+                     DAG.getNode(Op.getOpcode(), dl, NewVT, Lo),
+                     DAG.getNode(Op.getOpcode(), dl, NewVT, Hi));
+}
----------------
(No comment, but Phabricator won't let me delete this for some reason.)


Repository:
  rL LLVM

https://reviews.llvm.org/D26357





More information about the llvm-commits mailing list