[PATCH] D26321: [X86] Add LLVM version number for each intrinsic handled by auto upgrade for age tracking

[Simon Pilgrim via llvm-commits]

RKSimon added a comment.

The structure looks OK. I don't think it matters if the upgrade code itself has changed after the commented version (e.g. older SSE upgrades were improved to support AVX+ intrinsics as well).

I think we just need a comment at the top explaining our autoupgrade lifespan policy, but since the proposed changes to the version number increments I'm not sure what that still is.... Since we still have all that 3.X code there it obviously isn't at major increment.

The only other thing that we may want to consider is if there is a way to add a -Wdeprecated style warning to soon to be deleted upgrade paths, but given that this is called in IR tools I don't know the best way to do that.


https://reviews.llvm.org/D26321