[PATCH] D25381: [AMDGPU] Add amdgpu-unify-metadata pass

[Tom Stellard via llvm-commits]

tstellarAMD added a comment.

It seems like merging the OpenCl metadata would have to be done in an AMDGPU backend pass, since it uses rules specific to our target.  However, I think de-duplicating generic metadata like .ident should be handled in a target independent way.



================
Comment at: lib/Target/AMDGPU/AMDGPUUnifyMetadata.cpp:105
+    if (E == 1) return false;
+    std::string All;
+    bool First = true;
----------------
Would it be better to use Twine here?


Repository:
  rL LLVM

https://reviews.llvm.org/D25381