[PATCH] D26130: [ELF] - Implemented --symbol-ordering-file option.

[Ed Maste via llvm-commits]

emaste added a comment.

> If lld mislinks firefox, we shouldn't silently ignore it and try to link with gold, but open a bug instead (and/or try to fix).

A Firefox bug, it seems.

> if CONFIG['GCC_USE_GNU_LD']:

It looks like Firefox uses this rather unfortunate test:

  if test "$GNU_CC"; then
      if `$CC -print-prog-name=ld` -v 2>&1 | grep -c GNU >/dev/null; then
          GCC_USE_GNU_LD=1
      fi
  fi

and there's been a history of issues detecting the linker type, e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1049510.

I suspect we could set this to 1 also for lld (at least, I think it's reasonable that lld will support ld.bfd options or behaviour that Firefox relies on). However, it seems like someone familiar with Firefox ought to audit all of the uses of GCC_USE_GNU_LD and replace them with tests on the actual functionality required.


https://reviews.llvm.org/D26130