[PATCH] D24338: [InlineCost] Remove CallPenalty and change MinSizeThreshold to 5

[James Molloy via llvm-commits]

jmolloy updated this revision to Diff 77027.
jmolloy added a comment.

Hi David and Chandler,

Thanks for all these comments. I'm glad the two main reviewers agree with each other at this point :)

I've stripped this patch down to the basics - removing the skew. This one should be a no-brainer. Following up to this, I'd like to, in separate patches:

- Change the minsize threshold to 5, as I've determined through testing that setting it to zero leaves codesize and performance on the table due to the inaccuracy of the IR cost model.
- Improve TTI::getCallCost(), teaching it the tricks the inliner knows.
- Hopefully eventually switch to using getCallCost() in the inliner.

Does this sound acceptable?

Cheers,

James


Repository:
  rL LLVM

https://reviews.llvm.org/D24338

Files:
  lib/Analysis/InlineCost.cpp
  test/Transforms/Inline/alloca-bonus.ll
  test/Transforms/Inline/inline-cold-callee.ll
  test/Transforms/Inline/inline-cold.ll
  test/Transforms/Inline/inline-hot-callee.ll
  test/Transforms/Inline/inline-hot-callsite.ll
  test/Transforms/Inline/inline-optsize.ll
  test/Transforms/Inline/inline_unreachable-2.ll
  test/Transforms/Inline/optimization-remarks-passed-yaml.ll
  test/Transforms/Inline/ptr-diff.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24338.77027.patch
Type: text/x-patch
Size: 9131 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161107/022617c3/attachment.bin>