[PATCH] D26309: [MC][AArch64] Cleanup end-of-line parsing in AArch64 AsmParser.

Nirav Davé via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 05:52:55 PST 2016


parseToken emit an error if it doesn't parse the expected token.

-Nirav

On Sat, Nov 5, 2016 at 12:21 AM, Renato Golin <renato.golin at linaro.org>
wrote:

> rengolin added a comment.
>
> Small comments, otherwise, loos good.
>
>
>
> ================
> Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4163
> +
> +  if (parseToken(AsmToken::EndOfStatement))
> +    return true;
> ----------------
> Shouldn't this be emitting an error?
>
>
> ================
> Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4217
>
> +  if (parseToken(AsmToken::EndOfStatement))
> +    return true;
> ----------------
> here too
>
>
> https://reviews.llvm.org/D26309
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161107/2cd3d1bc/attachment.html>


More information about the llvm-commits mailing list