[PATCH] D25814: [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64

Sagar Thakur via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 6 22:40:02 PST 2016


slthakur added inline comments.


================
Comment at: test/msan/Linux/syscalls_sigaction.cc:21
+#if defined(__mips__)
+  long restorer;
+#endif
----------------
eugenis wrote:
> Are you sure that restorer follows mask? Length of the mask field (20 here) does not match any kernel definition - it is simply large enough to avoid out-of-bounds access.
> 
> The kernel definition does not seem to have a restorer field at all.
> 
Yes you are right, the sigaction structure for MIPS does not have a restorer field.


https://reviews.llvm.org/D25814





More information about the llvm-commits mailing list