[PATCH] D26327: Convert MIPS .reginfo section to synthetic input section.

[Rui Ueyama via llvm-commits]

Simon,

I have a question for you. I couldn't figure out how to fix the following
errors because I don't understand the exact formula how these constants are
calculated. Could you apply this and take a look at it for me?


[1/1] Running lld test suite
FAIL: lld :: ELF/mips-n32-rels.s (532 of 931)
******************** TEST 'lld :: ELF/mips-n32-rels.s' FAILED
********************
Script:
--
/ssd/build/./bin/ld.lld --full-shutdown
/ssd/llvm/tools/lld/test/ELF/Inputs/mips-n32-rels.o -o
/ssd/build/tools/lld/test/ELF/Output/mips-n32-rels.s.tmp.exe
/ssd/build/./bin/llvm-objdump -t -d -s
/ssd/build/tools/lld/test/ELF/Output/mips-n32-rels.s.tmp.exe |
/ssd/build/./bin/FileCheck /ssd/llvm/tools/lld/test/ELF/mips-n32-rels.s
/ssd/build/./bin/llvm-readobj -h
/ssd/build/tools/lld/test/ELF/Output/mips-n32-rels.s.tmp.exe |
/ssd/build/./bin/FileCheck -check-prefix=ELF
/ssd/llvm/tools/lld/test/ELF/mips-n32-rels.s
--
Exit Code: 1

Command Output (stderr):
--
/ssd/llvm/tools/lld/test/ELF/mips-n32-rels.s:41:15: error: expected string
not found in input
# CHECK-NEXT: 10128 00020004
              ^
<stdin>:16:2: note: scanning from here
 10110 00020004 ....
 ^

--

********************
FAIL: lld :: ELF/mips-gprel32-relocs-gp0.s (548 of 931)
******************** TEST 'lld :: ELF/mips-gprel32-relocs-gp0.s' FAILED
********************
Script:
--
/ssd/build/./bin/llvm-mc -filetype=obj -triple=mips-unknown-linux
/ssd/llvm/tools/lld/test/ELF/mips-gprel32-relocs-gp0.s -o
/ssd/build/tools/lld/test/ELF/Output/mips-gprel32-relocs-gp0.s.tmp.o
/ssd/build/./bin/ld.lld --full-shutdown -r -o
/ssd/build/tools/lld/test/ELF/Output/mips-gprel32-relocs-gp0.s.tmp-rel.o
/ssd/build/tools/lld/test/ELF/Output/mips-gprel32-relocs-gp0.s.tmp.o
/ssd/build/./bin/llvm-readobj -mips-reginfo
/ssd/build/tools/lld/test/ELF/Output/mips-gprel32-relocs-gp0.s.tmp-rel.o |
/ssd/build/./bin/FileCheck --check-prefix=REL
/ssd/llvm/tools/lld/test/ELF/mips-gprel32-relocs-gp0.s
/ssd/build/./bin/ld.lld --full-shutdown -shared -o
/ssd/build/tools/lld/test/ELF/Output/mips-gprel32-relocs-gp0.s.tmp.so
/ssd/llvm/tools/lld/test/ELF/Inputs/mips-gp0-non-zero.o
/ssd/build/./bin/llvm-readobj -mips-reginfo
/ssd/build/tools/lld/test/ELF/Output/mips-gprel32-relocs-gp0.s.tmp.so |
/ssd/build/./bin/FileCheck --check-prefix=DSO
/ssd/llvm/tools/lld/test/ELF/mips-gprel32-relocs-gp0.s
/ssd/build/./bin/llvm-objdump -s -t /ssd/build/tools/lld/test/ELF/Output/
mips-gprel32-relocs-gp0.s.tmp.so | /ssd/build/./bin/FileCheck
--check-prefix=DUMP /ssd/llvm/tools/lld/test/ELF/mips-gprel32-relocs-gp0.s
/ssd/build/./bin/not /ssd/build/./bin/ld.lld --full-shutdown -r -o
/ssd/build/tools/lld/test/ELF/Output/mips-gprel32-relocs-gp0.s.tmp-rel.o
/ssd/llvm/tools/lld/test/ELF/Inputs/mips-gp0-non-zero.o 2>&1    |
/ssd/build/./bin/FileCheck --check-prefix=ERR
/ssd/llvm/tools/lld/test/ELF/mips-gprel32-relocs-gp0.s
--
Exit Code: 1

Command Output (stderr):
--
/ssd/llvm/tools/lld/test/ELF/mips-gprel32-relocs-gp0.s:25:9: error:
expected string not found in input
# DUMP: 0114 ffff0004 ffff0008
        ^
<stdin>:5:2: note: scanning from here
 0114 fffe8014 fffe8018 ........
 ^

--

********************
Testing Time: 3.90s
********************
Failing Tests (2):
    lld :: ELF/mips-gprel32-relocs-gp0.s
    lld :: ELF/mips-n32-rels.s

On Sat, Nov 5, 2016 at 5:38 PM, Rui Ueyama <ruiu at google.com> wrote:

> ruiu created this revision.
> ruiu added a reviewer: atanasyan.
> ruiu added a subscriber: llvm-commits.
> Herald added a subscriber: sdardis.
>
> Previously, we have an input section and an output section
> for MIPS .reginfo. This patch reorganizes the code structure.
> Now we have only one class for .reginfo, which is MipsReginfoSection.
> MipsReginfoSection is a synthetic input section.
>
> .reginfo sections are handled as regular sections until the
> control reaches Writer. Writer then aggregates all sections whose
> type is SHT_MIPS_REGINFO to create a single synthesized input section.
> The synthesized section is then processed normally as if it came
> from an input file.
>
>
> https://reviews.llvm.org/D26327
>
> Files:
>   ELF/InputFiles.cpp
>   ELF/InputFiles.h
>   ELF/InputSection.cpp
>   ELF/InputSection.h
>   ELF/OutputSections.cpp
>   ELF/OutputSections.h
>   ELF/SyntheticSections.cpp
>   ELF/SyntheticSections.h
>   ELF/Writer.cpp
>   test/ELF/basic-mips.s
>   test/ELF/invalid/mips-multiple-reginfo.test
>   test/ELF/mips-64.s
>   test/ELF/mips-tls-64.s
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161105/33fc9854/attachment.html>