[PATCH] D26309: [MC][AArch64] Cleanup end-of-line parsing in AArch64 AsmParser.
Renato Golin via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 4 21:21:22 PDT 2016
rengolin added a comment.
Small comments, otherwise, loos good.
================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4163
+
+ if (parseToken(AsmToken::EndOfStatement))
+ return true;
----------------
Shouldn't this be emitting an error?
================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4217
+ if (parseToken(AsmToken::EndOfStatement))
+ return true;
----------------
here too
https://reviews.llvm.org/D26309
More information about the llvm-commits
mailing list