[llvm] r286031 - [X86] Remove broken support for autoupgrading llvm.x86.fma4.* intrinsics to llvm.x86.fma.*.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 4 21:00:32 PDT 2016


Author: ctopper
Date: Fri Nov  4 23:00:31 2016
New Revision: 286031

URL: http://llvm.org/viewvc/llvm-project?rev=286031&view=rev
Log:
[X86] Remove broken support for autoupgrading llvm.x86.fma4.* intrinsics to llvm.x86.fma.*.

It currently fires an assert if you even try. Looking back, I don't think it ever worked because it only changed the name of the function object, but not the intrinsic ID stored in it. Given that, I think it can be removed since no one has noticed or complained in the past 4 years.

Modified:
    llvm/trunk/lib/IR/AutoUpgrade.cpp

Modified: llvm/trunk/lib/IR/AutoUpgrade.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/AutoUpgrade.cpp?rev=286031&r1=286030&r2=286031&view=diff
==============================================================================
--- llvm/trunk/lib/IR/AutoUpgrade.cpp (original)
+++ llvm/trunk/lib/IR/AutoUpgrade.cpp Fri Nov  4 23:00:31 2016
@@ -403,12 +403,6 @@ static bool UpgradeIntrinsicFunction1(Fu
       NewFn = Intrinsic::getDeclaration(F->getParent(), ShiftID);
       return true;
     }
-    // Fix the FMA4 intrinsics to remove the 4
-    if (IsX86 && Name.startswith("fma4.")) {
-      rename(F);
-      NewFn = F;
-      return true;
-    }
     // Upgrade any XOP PERMIL2 index operand still using a float/double vector.
     if (IsX86 && Name.startswith("xop.vpermil2")) {
       auto Params = F->getFunctionType()->params();




More information about the llvm-commits mailing list