[llvm] r286009 - [Hexagon] Account for <def, read-undef> when validating moves for predication

[Krzysztof Parzyszek via llvm-commits]

Author: kparzysz
Date: Fri Nov  4 15:41:03 2016
New Revision: 286009

URL: http://llvm.org/viewvc/llvm-project?rev=286009&view=rev
Log:
[Hexagon] Account for <def,read-undef> when validating moves for predication

Added:
    llvm/trunk/test/CodeGen/Hexagon/expand-condsets-def-undef.mir
Modified:
    llvm/trunk/lib/Target/Hexagon/HexagonExpandCondsets.cpp

Modified: llvm/trunk/lib/Target/Hexagon/HexagonExpandCondsets.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonExpandCondsets.cpp?rev=286009&r1=286008&r2=286009&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Hexagon/HexagonExpandCondsets.cpp (original)
+++ llvm/trunk/lib/Target/Hexagon/HexagonExpandCondsets.cpp Fri Nov  4 15:41:03 2016
@@ -948,6 +948,13 @@ bool HexagonExpandCondsets::predicate(Ma
         return false;
 
       ReferenceMap &Map = Op.isDef() ? Defs : Uses;
+      if (Op.isDef() && Op.isUndef()) {
+        assert(RR.Sub && "Expecting a subregister on <def,read-undef>");
+        // If this is a <def,read-undef>, then it invalidates the non-written
+        // part of the register. For the purpose of checking the validity of
+        // the move, assume that it modifies the whole register.
+        RR.Sub = 0;
+      }
       addRefToMap(RR, Map, Exec);
     }
   }

Added: llvm/trunk/test/CodeGen/Hexagon/expand-condsets-def-undef.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Hexagon/expand-condsets-def-undef.mir?rev=286009&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Hexagon/expand-condsets-def-undef.mir (added)
+++ llvm/trunk/test/CodeGen/Hexagon/expand-condsets-def-undef.mir Fri Nov  4 15:41:03 2016
@@ -0,0 +1,41 @@
+# RUN: llc -march=hexagon -run-pass expand-condsets -o - %s -verify-machineinstrs | FileCheck %s
+
+# CHECK-LABEL: name: fred
+
+# Make sure that <def,read-undef> is accounted for when validating moves
+# during predication. In the code below, %2.subreg_hireg is invalidated
+# by the C2_mux instruction, and so predicating the A2_addi as an argument
+# to the C2_muxir should not happen.
+
+--- |
+  define void @fred() { ret void }
+
+...
+---
+
+name: fred
+tracksRegLiveness: true
+registers:
+  - { id: 0, class: predregs }
+  - { id: 1, class: intregs }
+  - { id: 2, class: doubleregs }
+  - { id: 3, class: intregs }
+liveins:
+  - { reg: '%p0', virtual-reg: '%0' }
+  - { reg: '%r0', virtual-reg: '%1' }
+  - { reg: '%d0', virtual-reg: '%2' }
+
+body: |
+  bb.0:
+    liveins: %r0, %d0, %p0
+    %0 = COPY %p0
+    %1 = COPY %r0
+    %2 = COPY %d0
+    ; Check that this instruction is unchanged (remains unpredicated)
+    ; CHECK: %3 = A2_addi %2.subreg_hireg, 1
+    %3 = A2_addi %2.subreg_hireg, 1
+    undef %2.subreg_loreg = C2_mux %0, %2.subreg_loreg, %1
+    %2.subreg_hireg = C2_muxir %0, %3, 0
+
+...
+