[PATCH] D26303: AMDGPU/SI: Fix visit order assumption in SIFixSGPRCopies

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 4 11:07:31 PDT 2016


tstellarAMD created this revision.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
Herald added subscribers: tony-tye, yaxunl, nhaehnle, wdng, kzhuravl.

This pass was assuming that when a PHI instruction defined a register
used by another PHI instruction that the defining insstruction would
be legalized before the using instruction.

This assumption was causing the pass to not legalize some PHI nodes
within divergent flow-control.

This fixes a bug that was uncovered by r285762.


https://reviews.llvm.org/D26303

Files:
  lib/Target/AMDGPU/SIFixSGPRCopies.cpp
  test/CodeGen/AMDGPU/salu-to-valu.ll
  test/CodeGen/MIR/AMDGPU/si-fix-sgpr-copies.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26303.76923.patch
Type: text/x-patch
Size: 4935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161104/436ce958/attachment.bin>


More information about the llvm-commits mailing list