[PATCH] D26257: [AVX512][llvm] Amending vpmultishiftqb

[Elena Demikhovsky via llvm-commits]

delena added inline comments.


================
Comment at: include/llvm/IR/IntrinsicsX86.td:2136
         GCCBuiltin<"__builtin_ia32_vpmultishiftqb128_mask">,
-        Intrinsic<[llvm_v16i8_ty], [llvm_v16i8_ty,
-                   llvm_v16i8_ty, llvm_v16i8_ty, llvm_i16_ty], [IntrNoMem]>;
+        Intrinsic<[llvm_v2i64_ty], [llvm_v2i64_ty,
+                   llvm_v2i64_ty, llvm_v2i64_ty, llvm_i16_ty], [IntrNoMem]>;
----------------
coby wrote:
> craig.topper wrote:
> > I think the result type should still be byte elements to match the number of elements in the write mask.
> 1. As far as practical matters is to be concerned - the 'raw' result will remain the same.
> 2. One may expect to be supplied with a result which is partitioned as it spec'd to be, i.e. at a qword granularity. hence, I think it should remain as such.
Craig is right. The result is a vector of byte elements and the mask type should correspond the result. Please fix.


Repository:
  rL LLVM

https://reviews.llvm.org/D26257