[PATCH] D25325: [ELF] Change way we place non-scripted (orphan) sections

[Eugene Leviant via llvm-commits]

Let's imagine that *NonScriptI points to NOBITS alloc section. Let's also
imagine that there are several alloc PROGBITS a sections before
*NonScriptI. Where will your patch insert *NonScriptI? If I am not mistaken
- after the very first PROGBITS section. If so this isn't correct. The
right thing is not to move it at all.

пятница, 4 ноября 2016 г. пользователь Rafael Espíndola написал:

> What do you think of the attached patch?
>
> It fixes your testcase and has a minimum impact on the existing tests.
> If this is OK for you, feel free to commit it.
>
> Once it is in we can try to simplify it further.
>
> Cheers,
> Rafael
>
>
> On 4 November 2016 at 08:43, Rafael Espíndola
> <rafael.espindola at gmail.com <javascript:;>> wrote:
> > Applying the patch to see if I con simplify the logic a bit.
> >
> >
> > On 1 November 2016 at 12:12, Eugene Leviant <evgeny.leviant at gmail.com
> <javascript:;>> wrote:
> >> evgeny777 removed rL LLVM as the repository for this revision.
> >> evgeny777 updated this revision to Diff 76574.
> >> evgeny777 added a comment.
> >>
> >> Two-pass approach
> >>
> >>
> >> https://reviews.llvm.org/D25325
> >>
> >> Files:
> >>   ELF/Writer.cpp
> >>   test/ELF/linkerscript/merge-sections.s
> >>   test/ELF/linkerscript/no-space.s
> >>   test/ELF/linkerscript/orphan.s
> >>   test/ELF/linkerscript/sections-constraint.s
> >>   test/ELF/linkerscript/sections-keep.s
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161104/1a88634c/attachment.html>