[PATCH] D26257: [AVX512][llvm] Amending vpmultishiftqb

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 15:30:39 PDT 2016


craig.topper added a comment.

Can you please clarify what the perceived problem is? The encodings already match your test case before this change and the result type change doesn't make sense given that the instruction really does write bytes.



================
Comment at: include/llvm/IR/IntrinsicsX86.td:2136
         GCCBuiltin<"__builtin_ia32_vpmultishiftqb128_mask">,
-        Intrinsic<[llvm_v16i8_ty], [llvm_v16i8_ty,
-                   llvm_v16i8_ty, llvm_v16i8_ty, llvm_i16_ty], [IntrNoMem]>;
+        Intrinsic<[llvm_v2i64_ty], [llvm_v2i64_ty,
+                   llvm_v2i64_ty, llvm_v2i64_ty, llvm_i16_ty], [IntrNoMem]>;
----------------
I think the result type should still be byte elements to match the number of elements in the write mask.


Repository:
  rL LLVM

https://reviews.llvm.org/D26257





More information about the llvm-commits mailing list