[PATCH] D26269: [APFloat] Make functions that produce APFloaat objects use correct semantics.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 12:23:23 PDT 2016


hfinkel added a comment.

Can you please explain the problem/solution?



================
Comment at: llvm/include/llvm/ADT/APFloat.h:645
+    explicit Storage(DoubleAPFloat F, const fltSemantics &S)
+        : Double(std::move(F)) {}
 
----------------
Why is S unused? If we're assuming that `semantics` is initialized elsewhere, a comment would be useful explaining why we have the argument.


https://reviews.llvm.org/D26269





More information about the llvm-commits mailing list