[llvm] r285937 - Delete some dead code and add a missing "0x" prefix to a hex string in

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 10:11:11 PDT 2016


Author: chandlerc
Date: Thu Nov  3 12:11:11 2016
New Revision: 285937

URL: http://llvm.org/viewvc/llvm-project?rev=285937&view=rev
Log:
Delete some dead code and add a missing "0x" prefix to a hex string in
llvm-readobj.

Another bug caught by PVS-Studio.

It'd be nice to actually have a test for this, but I found it by
inspection from PVS-Studio.

Modified:
    llvm/trunk/tools/llvm-readobj/ELFDumper.cpp

Modified: llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/ELFDumper.cpp?rev=285937&r1=285936&r2=285937&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-readobj/ELFDumper.cpp (original)
+++ llvm/trunk/tools/llvm-readobj/ELFDumper.cpp Thu Nov  3 12:11:11 2016
@@ -2389,8 +2389,7 @@ template <class ELFT> void GNUStyle<ELFT
   OS << "\n";
   Str = printEnum(e->e_ident[ELF::EI_OSABI], makeArrayRef(ElfOSABI));
   printFields(OS, "OS/ABI:", Str);
-  Str = "0x" + to_hexString(e->e_version);
-  Str = to_hexString(e->e_ident[ELF::EI_ABIVERSION]);
+  Str = "0x" + to_hexString(e->e_ident[ELF::EI_ABIVERSION]);
   printFields(OS, "ABI Version:", Str);
   Str = printEnum(e->e_type, makeArrayRef(ElfObjectFileType));
   printFields(OS, "Type:", Str);




More information about the llvm-commits mailing list