[PATCH] D25496: [lit] Remove TODO

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 3 09:58:23 PDT 2016


delcypher added a comment.

@modocache

> I'd appreciate it if you could create a problem report for "Support valgrind in all configs, and LLVM style valgrind", @delcypher! I'm not sure I understand what is and isn't supported.

I'm not entirely sure what this is either. lit can run tools under valgrind but I'm not sure if valgrind is actively used much these days for LLVM development. There are valgrind suppression files in the LLVM source tree (`utils/valgrind`) but they haven't been touched in a while but I'm guessing that's what this TODO was referring to. Really the idea of running the tests with a supervising tool needs to be generalized so arbitary stuff can be plugged in. For example it might be useful to have the system debugger attached to every process spawned so if one of them crashes it's easy to see what happened.

I could create a problem report for that if you like.

Also sorry for my slowness in replying :(


https://reviews.llvm.org/D25496





More information about the llvm-commits mailing list