[PATCH] D25590: Add initial support for WebAssembly binary format

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 17:02:44 PDT 2016


sunfish added inline comments.


================
Comment at: lib/Object/WasmObjectFile.cpp:199
+        break;
+      default:
+        Err = make_error<GenericBinaryError>("Bad section type",
----------------
It'd be good to handle WASM_SEC_USER here too. If I understand the code here, we don't need to actually parse it, for now, similar to WASM_SEC_CODE above.


https://reviews.llvm.org/D25590





More information about the llvm-commits mailing list