[PATCH] D26256: [InstCombine] Don't set debug location when folding through a phi node

Dehao Chen via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 14:35:41 PDT 2016


danielcdh added a comment.

>From the implementation point of view, the map from source location to the maximum discriminator that source location has, is only maintained in AddDiscriminators.cpp. So at later optimizations, you cannot find the maximum discriminator for that location, and assign max_discriminator+1 to the moved instruction.


https://reviews.llvm.org/D26256





More information about the llvm-commits mailing list