[PATCH] D26199: [ELF] - Implemented threaded --build-id computation

[Ed Maste via llvm-commits]

emaste added inline comments.


================
Comment at: ELF/InputSection.cpp:897
+// If threads are used, --build-id=tree splits input data by chunks.
+// MD5 hash is calculated for each one and then SHA1 hash is
+// calculated for result sequence.
----------------
This seems like a strange combination. Why not just SHAx?


================
Comment at: ELF/InputSection.cpp:907
+
+  // Default chunk size is 1 megabyte.
+  const size_t ChunkSize = 1024 * 1024;
----------------
We don't have a way to select another size so "default" doesn't seem right


https://reviews.llvm.org/D26199