[PATCH] D26220: Emit one CodeView S_COMPILE3 record per TU rather than per function

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 14:01:16 PDT 2016


amccarth marked 6 inline comments as done.
amccarth added inline comments.


================
Comment at: test/DebugInfo/COFF/multifunction.ll:58
 ; X86-NEXT: .long   241
 ; X86-NEXT: .long [[F1_END:.*]]-[[F1_START:.*]] #
 ; Compiler information record
----------------
rnk wrote:
> This is supposed to test how we emit one symbol subsection per function, so I think it's worth matching the compile info subsection.
> 
> The names F1_START and F1_END were intended to refer to the symbol subsection for x, but this is actually the compile info subection now. Let's use F1_START / F1_END in place of SUBSEC_START / SUBSEC_END and use COMPILE_START / COMPILE_END here.
Yeah, duh.  I realized that mistake earlier, but promptly forgot about it.


https://reviews.llvm.org/D26220





More information about the llvm-commits mailing list