[PATCH] D26259: Bitcode: Decouple block info block state from reader.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 13:24:54 PDT 2016


pcc created this revision.
pcc added reviewers: dexonsmith, mehdi_amini.
pcc added a subscriber: llvm-commits.

As proposed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-October/106630.html

Move block info block state to a new class, BitstreamBlockInfo.
Clients may set the block info for a particular cursor with the
BitstreamCursor::setBlockInfo() method.

At this point BitstreamReader is not much more than a container for an
ArrayRef<uint8_t>, so remove it and replace all uses with direct uses
of memory buffers.


https://reviews.llvm.org/D26259

Files:
  clang/include/clang/CodeGen/ObjectFilePCHContainerOperations.h
  clang/include/clang/Frontend/PCHContainerOperations.h
  clang/include/clang/Serialization/Module.h
  clang/include/clang/Serialization/ModuleManager.h
  clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
  clang/lib/Frontend/PCHContainerOperations.cpp
  clang/lib/Frontend/SerializedDiagnosticReader.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/GlobalModuleIndex.cpp
  clang/lib/Serialization/ModuleManager.cpp
  llvm/include/llvm/Bitcode/BitstreamReader.h
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Reader/BitstreamReader.cpp
  llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
  llvm/unittests/Bitcode/BitstreamReaderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26259.76773.patch
Type: text/x-patch
Size: 39992 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161102/7f1ebea9/attachment-0001.bin>


More information about the llvm-commits mailing list