[PATCH] D26123: Fix SegFault in Expected

[Yichao Yu via llvm-commits]

yuyichao added a comment.

> Since this started causing problems after r285426, I'm wondering what the reproducer looks like / why we haven't seen this issue already.

Any code that doesn't check for the error when assertion is disabled should trigger this error and the reason was that r285426 introduces the tag bit in this case. The code path we had to trigger it is https://github.com/JuliaLang/julia/blob/10ffbaeaa809a5a9cdc7866aa659ad2a4e525a6a/src/debuginfo.cpp#L1255, which clears the error before assigning the next attempt to it if assertion is enabled.


https://reviews.llvm.org/D26123