[PATCH] D26173: [lli/COFF] Set the correct alignment for common symbols

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 10:28:36 PDT 2016


davide added inline comments.


================
Comment at: test/ExecutionEngine/MCJIT/coff-alignment.ll:5-8
+define void @main() {
+  %tmp23 = load i32, i32* @o, align 4
+  ret void
+}
----------------
rnk wrote:
> Want to return the i32 from main so that this isn't fragile to codegen changes?
Sure. Thanks for your review, Reid.


https://reviews.llvm.org/D26173





More information about the llvm-commits mailing list