[PATCH] D26248: [AArch64] Removed the narrow load merging code in the ld/st optimizer.

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 2 09:03:44 PDT 2016


mcrosier created this revision.
mcrosier added a reviewer: junbuml.
mcrosier added subscribers: gberry, t.p.northover, rengolin, llvm-commits.
Herald added a subscriber: aemerson.

This feature has been disabled for some time now due to reports of performance regressions.  Since no one has complained and we've moved on to 4.0 I'd like to remove this code permanently.

This should be a NFC for all AArch64 subtargets.

The FeatureMergeNarrowLd used to control merging of both narrow loads and narrow zero stores (which was a bit misleading).  I've renamed it to FeatureMergeNarrowSt to be more inline with what's actually happening.

Currently, narrow zero stores are only merged for Kryo and Cortex-A57.  I suspect this would benefit other subtargets, but I'll leave that to the respective owners to decide.

Chad


https://reviews.llvm.org/D26248

Files:
  lib/Target/AArch64/AArch64.td
  lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
  lib/Target/AArch64/AArch64Subtarget.h
  test/CodeGen/AArch64/arm64-narrow-ldst-merge.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26248.76714.patch
Type: text/x-patch
Size: 29786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161102/fddcc791/attachment.bin>


More information about the llvm-commits mailing list