[PATCH] D25601: DAGCombiner: fix use-after-free when merging consecutive stores

[Nicolai Hähnle via llvm-commits]

nhaehnle added a comment.

Sorry for the slow response, had some other bugs to deal with. I'll address the comments now.

There are lots of lit tests that hit this when you apply https://reviews.llvm.org/D25313, unfortunately I didn't take a note of which ones precisely because there were so many... I don't think they manifest as actual miscompiles because the deleted nodes land in the Recycler, and nothing allocates a new node in the meantime. But it's certainly fragile...


https://reviews.llvm.org/D25601