[PATCH] D24613: [AAP] (9) Add the bulk of the AAP backend implementation

[Simon Cook via llvm-commits]

simoncook added inline comments.


================
Comment at: lib/Target/AAP/AAPAsmPrinter.cpp:89
+  printOperand(MI, OpNum, O);
+  O << ',' << ' ';
+  printOperand(MI, OpNum + 1, O);
----------------
Why do you stream this as two characters, rather than as a two byte string?


================
Comment at: lib/Target/AAP/AAPFrameLowering.cpp:126
+    MachineBasicBlock::iterator I) const {
+  assert(!hasFP(MF) && "Frame pointer unsupported!");
+  return MBB.erase(I);
----------------
Presumably this is a FIXME to be implemented?


================
Comment at: lib/Target/AAP/AAPISelLowering.cpp:100
+  setOperationAction(ISD::VASTART, MVT::Other, Custom);
+  setOperationAction(ISD::VAARG, MVT::Other,  Expand);
+  setOperationAction(ISD::VAEND, MVT::Other,  Expand);
----------------
nitpic: You've aligned other blocks of actions, but not this?


https://reviews.llvm.org/D24613