[PATCH] D23772: [AAP] (6) Add AAP AsmParser
Simon Cook via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 1 15:55:18 PDT 2016
simoncook added inline comments.
================
Comment at: lib/Target/AAP/AsmParser/AAPAsmParser.cpp:195
+
+ static bool isConst3(const MCExpr *I) {
+ if (!isConst(I))
----------------
The function above takes an argument called Imm, but this and the others take an argument called I. Given I tends to mean Instruction, perhaps renaming this argument Imm.
https://reviews.llvm.org/D23772
More information about the llvm-commits
mailing list