[PATCH] D26212: IRMover: Avoid accidentally mapping types from the destination module (PR30799)

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 14:56:03 PDT 2016


mehdi_amini added a comment.

> During Module linking, it's possible for SrcM->getIdentifiedStructTypes(); to return types that are actually defined in the destination module (DstM).

That's very surprising to me and I'd like to understand it a bit more  (We're supposed to only ODR metadata).
getIdentifiedStructTypes() isn't even documented in the Module header unfortunately. It is not clear off-hand it the issue should be handled in the IRMover or in `getIdentifiedStructTypes` itself.


https://reviews.llvm.org/D26212





More information about the llvm-commits mailing list