[llvm] r285744 - [ValueTracking] remove TODO comment; NFC
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 1 13:43:01 PDT 2016
Author: spatel
Date: Tue Nov 1 15:43:00 2016
New Revision: 285744
URL: http://llvm.org/viewvc/llvm-project?rev=285744&view=rev
Log:
[ValueTracking] remove TODO comment; NFC
InstCombine should always canonicalize patterns like the one shown in the comment
when visiting 'select' insts in adjustMinMax().
Scalars were already handled there, and vector splats are handled after:
https://reviews.llvm.org/rL285732
Modified:
llvm/trunk/lib/Analysis/ValueTracking.cpp
Modified: llvm/trunk/lib/Analysis/ValueTracking.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ValueTracking.cpp?rev=285744&r1=285743&r2=285744&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ValueTracking.cpp (original)
+++ llvm/trunk/lib/Analysis/ValueTracking.cpp Tue Nov 1 15:43:00 2016
@@ -3991,8 +3991,6 @@ static SelectPatternResult matchSelectPa
}
}
- // TODO: (X > 4) ? X : 5 --> (X >= 5) ? X : 5 --> MAX(X, 5)
-
return {SPF_UNKNOWN, SPNB_NA, false};
}
More information about the llvm-commits
mailing list