[PATCH] D26201: [ELF/GC] Fix pending references to garbage collected sections

[Michael Spencer via llvm-commits]

Bigcheese added inline comments.


================
Comment at: test/ELF/gc-debuginfo-tls.s:19-28
+      .file   1 "patatino.cpp"
+      .globl  main
+main:
+      .loc    1 2 0
+      .cfi_startproc
+      .cfi_endproc
+      .cfi_startproc
----------------
davide wrote:
> Bigcheese wrote:
> > This is a pretty obfuscated way to get a TLS symbol to a gced section. I think this can be simplified to something like:
> > 
> > ```
> >   .section .tbss,"awT", at nobits
> > patatino:
> >   .long 0
> >   .section .noalloc,""
> >   .quad patatino
> > ```
> This is reduced from the original testcase. But sure, I can add another test case if you want.
Sure, just add a comment to the .cfi* one saying that it was reduced from a testcase and that the debug info directives are generating the reference.


https://reviews.llvm.org/D26201