[PATCH] D25667: Fix call sites with spurious .c_str() calls from explicit StringRef conversion (NFC)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 10:27:23 PDT 2016


> On Nov 1, 2016, at 10:21 AM, Malcolm Parsons <malcolm.parsons at gmail.com> wrote:
> 
> On 1 November 2016 at 16:40, Mehdi Amini via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> 
>> If anyone want to pick it up…
> 
> I'll run clang-tidy's readability-redundant-string-cstr check and
> submit patches.

Great!

But I think you’ll have to change it: IIUC it catches string -> string conversion only (i.e. this likely won’t catch conversion to StringRef, or conversion from other than std::string).

— 
Mehdi





More information about the llvm-commits mailing list