[PATCH] D26130: [ELF] - Implemented --symbol-ordering-file option.

[George Rimar via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Writer.cpp:679
+  // Build sections order map from symbols list.
+  DenseMap<InputSectionBase<ELFT> *, unsigned> SectionsOrder;
+  for (size_t I = 0; I < Config->SymbolOrderingFile.size(); ++I) {
----------------
rafael wrote:
> This is crazy inefficient.
> 
> You probably want to make SymbolOrderingFile a DenseMap from CachedStringRef to unsigned.
Yeah.. that was stupid from my side. I am going to address this one and other comments tomorrow.


https://reviews.llvm.org/D26130