[PATCH] D25667: Fix call sites with spurious .c_str() calls from explicit StringRef conversion (NFC)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 09:40:34 PDT 2016


Hi David,

Thanks for pinging :)
This patch is rebased on top of other commits that didn’t go through, and I have spent a lot more time than I initially allocated for this work. The cost / benefit ratio has fallen under the threshold where it is worth me spending too much time! ;)

If anyone want to pick it up…

— 
Mehdi



> On Oct 31, 2016, at 11:09 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> I mean since you made the change & all, it still seems worth checking in - but up to you, of course.
> 
> On Thu, Oct 27, 2016 at 2:18 PM Mehdi AMINI via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> mehdi_amini abandoned this revision.
> mehdi_amini added a comment.
> 
> Closing since https://reviews.llvm.org/D25639 <https://reviews.llvm.org/D25639> went dead.
> 
> 
> https://reviews.llvm.org/D25667 <https://reviews.llvm.org/D25667>
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161101/2d786b2c/attachment.html>


More information about the llvm-commits mailing list