[PATCH] D25034: [AVR] Add instruction selection lowering code
Krzysztof Parzyszek via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 1 06:30:09 PDT 2016
kparzysz accepted this revision.
kparzysz added a comment.
This revision is now accepted and ready to land.
LGTM with a few comments.
================
Comment at: lib/Target/AVR/AVRISelLowering.cpp:884
+ return G->getSymbol();
+ } else if (const GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(Callee)) {
+ return G->getGlobal()->getName();
----------------
Else after return, same below.
================
Comment at: lib/Target/AVR/AVRISelLowering.cpp:1802
+ return std::make_pair(0U, &AVR::GPR8RegClass);
+ } else {
+ return std::make_pair(0U, &AVR::DREGSRegClass);
----------------
Same here.
Repository:
rL LLVM
https://reviews.llvm.org/D25034
More information about the llvm-commits
mailing list