[lld] r285682 - Convert BuildIdSection to input section

[Eugene Leviant via llvm-commits]

Rui initially suggested making writeTo a virtual function, so my first
thought was you're going to implement his idea.
Regarding your question: you probably mean that writeBuildId can
calculate offset using
In<ELFT>::BuildId->OutSec->getFileOffset() + In<ELFT>::BuildId->OutsecOff ?

Anyway I don't mind removing OutputLoc.

2016-11-01 15:11 GMT+03:00 Rafael Espíndola <rafael.espindola at gmail.com>:
> On 1 November 2016 at 08:08, Eugene Leviant <evgeny.leviant at gmail.com> wrote:
>> It's unlikely I'd need it anywhere else except BuildIdSection. Are you
>> going to virtualize writeTo and remove it?
>
> Sorry, it is not immediately clear why it needs the member or a
> virtual function. Doesn't the caller know where the section has to be
> written to?
>
> Cheers,
> Rafael