[PATCH] D26043: Replace GAlloc with a template function.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 1 05:09:04 PDT 2016


Ping on the commit :-)

Cheers,
Rafael


On 28 October 2016 at 18:22, Rui Ueyama <ruiu at google.com> wrote:
> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/Memory.cpp:23
> +
> +void elf::freeArena() {
> +  for (SpecificAllocBase *Alloc : SpecificAllocBase::Instances)
> ----------------
> rafael wrote:
>> Do we still need to free this at a specific point in time? If not just letting the destructors take care of it should simplify the code.
> This is for the use case in which you directly call lld::elf::link from your program. In that use case, we want to free all memories before returning from link().
>
>
> https://reviews.llvm.org/D26043
>
>
>


More information about the llvm-commits mailing list