[PATCH] D25587: Introduce llvm FormatVariadic

[Sean Silva via llvm-commits]

silvas added a comment.

It would be awesome if as a follow-up, you added a section to docs/ProgrammersManual.rst comparing string formatting options in LLVM (AFAIK, we now have this new shiny stuff, llvm::format, and raw_svector_ostream/raw_string_ostream). That should hopefully prevent new uses of the old stuff from creeping in (providing some good examples in there for common uses of the new stuff would also be good for helping this).

Also, it would be great if once this has landed, you manually verified that the doc comments end up looking "right" in the doxygen. Many LLVM developers that don't use IDE's will google for "llvm format_string" in hope of finding a doxygen page.


https://reviews.llvm.org/D25587